feat: add rename table interface to catalog #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
reviewed
Nov 2, 2025
wgtmac
requested changes
Nov 10, 2025
src/iceberg/transaction.h
Outdated
| /// \return Status::OK if all updates were queued successfully | ||
| virtual Status UpdateTable( | ||
| const std::vector<std::unique_ptr<TableRequirement>>& requirements, | ||
| std::vector<std::unique_ptr<TableUpdate>> updates) = 0; |
Member
There was a problem hiding this comment.
Suggested change
| std::vector<std::unique_ptr<TableUpdate>> updates) = 0; | |
| const std::vector<std::unique_ptr<TableUpdate>>& updates) = 0; |
wgtmac
reviewed
Nov 11, 2025
src/iceberg/transaction.h
Outdated
| /// \param requirements the table requirements to validate | ||
| /// \param updates the table updates to apply | ||
| /// \return Status::OK if all updates were queued successfully | ||
| virtual Status UpdateTable( |
Member
There was a problem hiding this comment.
Why do we need this? I don't think Transaction is the entrance to create a single update action and Catalog is responsible of this. Let's remove it.
wgtmac
changed the title
wgtmac
approved these changes
Nov 11, 2025
HeartLinked
approved these changes
Nov 11, 2025
| #pragma once | ||
|
|
||
| #include <memory> | ||
| #include <vector> |
HuaHuaY
reviewed
Nov 11, 2025
|
|
||
| Status InMemoryCatalog::RenameTable(const TableIdentifier& from, | ||
| const TableIdentifier& to) { | ||
| std::unique_lock lock(mutex_); |
Contributor
There was a problem hiding this comment.
If we don't need to move lock, we can use std::lock_guard<> instead. Can you help to modify the other cases in this file? Or we can open a new PR to do this.
Member
|
Thanks @lishuxu for working on this and @shangxinli @HuaHuaY @HeartLinked for the review. Let's improve it in followup PRs and move forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.